Wednesday Playbook
Our Services
  • Welcome to our Playbook
  • What we do
    • Our Services
      • Catalyse - For companies looking for staff augmentation services
      • Launch - Startups and Early Stage Companies
      • Control - Fast-paced tight-deadline projects with moonshot ROI potential
      • Amplify - Scaleups and Hyper-Growth Companies
      • Do's and don'ts
      • Ceremonies
    • Our Partner Programs
      • Agency Partner Program
      • Advisor/Consultant Partner Program
      • Investor Partner Program
      • Developer Tooling Partner Program
  • Employee Handbook
    • How We Work
      • Our Values
      • Our Dream Team
      • Our Leave Policy
      • Out of Office
      • Communication
      • Security Practices
      • Hiring Philosophy
    • Employment Policies
      • Equal Opportunity Employment
      • At-Will Employment Policy
      • Code of Conduct
      • Employee Privacy
      • Compensation
      • Performance Appraisal Policy
        • Timeline for each appraisal cycle
        • Guidelines for Self, Manager, Peer & Colleague Reviews
    • Starting at Wednesday
      • Your first day
        • Onboarding Checklist
      • Becoming a permanent employee
      • Getting Paid
      • Dress Code
      • Work Hours
    • Benefits and Perks
      • Holiday List
      • Paid Time Off
      • Group Health Insurance
      • Conferences
      • Hardware & Software Licenses
  • Engineering Playbook
    • Introduction to Our Engineering Playbook
    • System Architecture & Design
      • Templates
    • Release Engineering
      • Git-flow
      • Code reviews
      • Commit Messages
      • Pull requests
      • Continuous Integration and Delivery
    • Careers in Engineering
      • Hiring Engineers
      • Career Growth
  • DESIGN PLAYBOOK
    • Introduction to Our Design Playbook
    • Who we are
      • Our Journey
    • Why Us
      • Our Values As Designers
    • Careers in Product Design
      • Hiring Designers
  • Project Management Playbook
    • Introduction to Our Project Management Playbook
    • General Guidelines
      • Checklists
        • Internal Checklist
        • Customer Onboarding Checklist
    • Our Approach
      • Agile Ceremonies
        • Sprint Planning
        • Standups
        • Retrospectives & Demos
      • Stakeholder Management
        • Documentation
      • Team Management
    • Careers in Project Management
      • Career Growth
  • Communications
    • Introduction to Our Communications Playbook
    • Content
      • Channels
      • Process
        • Articles
          • Article Structure
            • Introduction Section
            • Instruction Sections
            • Getting Started Section
            • Theory Section
            • Reference Sections
            • "Where to go from here" section
          • Choose your topic
          • Write your outline
            • Research the topic
            • Create your article outline
          • Sample project
            • Follow the four commandments
            • Create a starter project
          • First draft
            • Think of the reader as a beginnner
            • Stay in limit
            • Make it scannable
            • Explain Code
          • Polish your draft
            • Use Hemingway
            • Review as a reader
    • Brand Assets
      • Wednesday
      • The Wednesday University
      • The Wednesday Show
  • Legal Templates
    • Client Contracts
      • Fixed Cost
        • Master Services Agreement for Fixed Cost
        • Statement of Work for Fixed Cost Projects
      • Time and Material
        • Master Services Agreement for T&M
        • Statement Of Work for T&M Projects
    • Personnel Contracts
      • Internship Offer & Intent to Hire
        • Internship Offer Template
        • Annexure 1 - List of Documents for Interns
        • Acknowledgment of Receipt of Playbook for Interns
        • Letter of Intent to Hire
      • Offer cum Appointment Letter for full-time personnel
        • Offer Cum Acceptance Letter Template
        • Annexure 1 - List of Documents for Personnel
        • Acknowledgment of Receipt of Playbook for Personnel
      • Contractor Agreement
        • Contractor Agreement Template
        • Annexure A
  • Elsewhere
    • Our Products
    • The Wednesday Show
    • Wednesday University
Powered by GitBook
On this page

Was this helpful?

Edit on Git
  1. Engineering Playbook
  2. Release Engineering

Code reviews

A quick look at how we do Code Reviews at Wednesday. What it consists of, and a few guidelines that we stick to.

Code reviews are a fundamental part of ensuring what we deliver works well and adheres to our style guides and quality control standards.

Each pull request needs to be reviewed and signed-off by a team member.

While reviewing a pull request please ensure you follow these guidelines:

  • Take time: Never review in a hurry. It's a recipe for disaster.

  • Test: Pull the branch locally and test the feature. If you see the feature in action you will be able to review it better.

  • Read the description: Ensure the pull request has a brief description of the feature or enhancement. It's very important to get context from the author's perspective.

  • Be positive: We're all on the same team. Any kind of slander or provocation is not okay.

  • Ask questions: If something isn't making sense seek an answer from the author.

  • Legibility: Legible code is more reusable and future-proof. The author will always feel like it's readable but you as the reviewer are the real judge of this. Everything in terms of variable names, function names, class names, and modules should be understandable.

PreviousGit-flowNextCommit Messages

Last updated 1 year ago

Was this helpful?